Use strict equalities in web/* #5108
Conversation
timvandermeij
changed the title
|
@Snuffleupagus Could you review this? |
Sure, I'll look at both of them! |
| @@ -225,7 +225,7 @@ var StepperManager = (function StepperManagerClosure() { | |||
| var options = stepperChooser.options; | |||
| for (i = 0; i < options.length; ++i) { | |||
| var option = options[i]; | |||
| option.selected = option.value == pageIndex; | |||
| option.selected = option.value === pageIndex; | |||
There was a problem hiding this comment.
option.value is a string, and pageIndex is an integer. Interestingly enough this change doesn't break anything, but I still think this should be changed to e.g.
(option.value | 0) === pageIndex;There was a problem hiding this comment.
Interesting indeed because I tested it and I thought it was fine because there was no difference in behavior. Good catch, sorry for missing that!
|
Good to go with comment addressed! |
|
I'll adress that right away and merge it. PS: I'm on IRC for any coordination on these changes. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6c7373978b0a22f/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6c7373978b0a22f/output.txt Total script time: 0.74 mins Published
|
Use strict equalities in web/*
No description provided.