-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Collect More Telemetry Data #4952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ccf7a801d6e9c65/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5558e375840fdef/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/ccf7a801d6e9c65/output.txt Total script time: 2.74 mins
Image differences available at: http://107.22.172.223:8877/ccf7a801d6e9c65/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/00a7480047a8cbc/output.txt |
return subtype === 'Type1C' ? FontType.TYPE1C : FontType.TYPE1; | ||
case 'CIDFontType0': | ||
return subtype === 'CIDFontType0C' ? FontType.CIDFONTTYPE0C : | ||
FontType.CIDFONTTYPE0C; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a typo: the same font type is used on both lines, shouldn't it be FontType.CIDFONTTYPE0
here?
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/5558e375840fdef/output.txt Total script time: 24.01 mins
Image differences available at: http://107.21.233.14:8877/5558e375840fdef/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/00a7480047a8cbc/output.txt Total script time: 21.78 mins
Image differences available at: http://107.22.172.223:8877/00a7480047a8cbc/reftest-analyzer.html#web=eq.log |
return new RunLengthStream(stream, maybeLength); | ||
} | ||
if (name == 'JBIG2Decode') { | ||
xrefStreamStats[StreamType.JPX] = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: should be StreamType.JBIG
.
Telemetry.registerAddonHistogram(ADDON_ID, "PDF_VIEWER_FORM", 1, 2, 3, Telemetry.HISTOGRAM_BOOLEAN); | ||
Telemetry.registerAddonHistogram(ADDON_ID, "PDF_VIEWER_STREAM_TYPES", 1, 9, 10, Telemetry.HISTOGRAM_LINEAR); | ||
Telemetry.registerAddonHistogram(ADDON_ID, "PDF_VIEWER_PRINT", 1, 2, 3, Telemetry.HISTOGRAM_BOOLEAN); | ||
Telemetry.registerAddonHistogram(ADDON_ID, "PDF_VIEWER_STREAM_TYPES", 1, 19, 20, Telemetry.HISTOGRAM_LINEAR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked at #telemetry, it's okay to change if we did not report any data for that yet
r=me with passing tests. /botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1eb8c13690a2eec/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/27e0e41aae4d1c7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/27e0e41aae4d1c7/output.txt Total script time: 21.62 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1eb8c13690a2eec/output.txt Total script time: 24.23 mins
|
Collect More Telemetry Data
Thank you! |
Fixes #4078
Collects: