Skip to content

Refactors loadFont for translateFont be async #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2014

Conversation

yurydelendik
Copy link
Contributor

translateFont is using CMapFactory.create which is sync network bound operation, this PR is preparing loadFont for that translateFont be async. Also, fixes type3 fonts to avoid sending operatorList with each character -- the bug surfaced when the loadFont promise was introduced, so cannot disconnect those without introducing the performance regression first.

@yurydelendik yurydelendik changed the title Refactors loadFont for translateFont be async [WIP] Refactors loadFont for translateFont be async May 19, 2014
@yurydelendik yurydelendik changed the title [WIP] Refactors loadFont for translateFont be async Refactors loadFont for translateFont be async May 19, 2014
@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/16721fbf358dff3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/05b13652533804d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/05b13652533804d/output.txt

Total script time: 2.70 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/05b13652533804d/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor Author

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/343506f0b7a4e36/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/16721fbf358dff3/output.txt

Total script time: 26.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/343506f0b7a4e36/output.txt

Total script time: 24.38 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Snuffleupagus added a commit that referenced this pull request May 20, 2014
Refactors loadFont for translateFont be async
@Snuffleupagus Snuffleupagus merged commit fe27a76 into mozilla:master May 20, 2014
@Snuffleupagus
Copy link
Collaborator

Looks good to me; thank you for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants