-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Refactors loadFont for translateFont be async #4815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/16721fbf358dff3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/05b13652533804d/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/05b13652533804d/output.txt Total script time: 2.70 mins
Image differences available at: http://107.22.172.223:8877/05b13652533804d/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/343506f0b7a4e36/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/16721fbf358dff3/output.txt Total script time: 26.66 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/343506f0b7a4e36/output.txt Total script time: 24.38 mins
|
Refactors loadFont for translateFont be async
Looks good to me; thank you for the patch! |
translateFont is using CMapFactory.create which is sync network bound operation, this PR is preparing loadFont for
thattranslateFont be async. Also, fixes type3 fonts to avoid sending operatorList with each character -- the bug surfaced when the loadFont promise was introduced, so cannot disconnect those without introducing the performance regression first.