-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Uses rAF to interrupt the operator list execution #4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/77c32b99d82e342/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/77c32b99d82e342/output.txt Total script time: 0.85 mins Published
|
http://people.mozilla.org/~bgirard/cleopatra/#report=58f2d95288f66f07a343c8f2585683da3303c731 That was fast! Looking at the profile everything looks great! Notice the 'Scripts' blocks in the profile? That's the rAF tied to the rendering. Right now your rendering chunks are 15ms. The web platforms will need some time to prepare a frame to send to the OS so say add 5ms (or more for complex changes) means that you wont fit inside the 16.6ms budget for 60 FPS. This means that you're going to drop down to 50-30 FPS (depending on how the platform VSync) while you're loading which isn't terrible. It's a trade-off between smoothness while loading and getting as much done. I should mention that unlike timeouts which are throttled, rAF wont be called at all when the tab is not visible. If background loading is important you will want to deal with that. Great work! |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1220ea46d0dd397/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e94b8c0ab5ee7a1/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/e94b8c0ab5ee7a1/output.txt Total script time: 2.81 mins
Image differences available at: http://107.22.172.223:8877/e94b8c0ab5ee7a1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1220ea46d0dd397/output.txt Total script time: 25.93 mins
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d432fd59f52941f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d432fd59f52941f/output.txt Total script time: 23.67 mins
|
Uses rAF to interrupt the operator list execution
Attempt to address #4762
/cc @bgirard