Properly disable presentation mode when the viewer is embedded #3641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/bd4d9ead2f1e11a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/bd4d9ead2f1e11a/output.txt Total script time: 0.21 mins Published |
|
Rebased to avoid merge conflicts. |
brendandahl
added a commit
that referenced
this pull request
Sep 17, 2013
…tionMode-when-embedded Properly disable presentation mode when the viewer is embedded
Snuffleupagus
deleted the
properly-disable-presentationMode-when-embedded
branch
yurydelendik
added a commit
to yurydelendik/pdf.js
that referenced
this pull request
Mar 27, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently presentation mode isn't properly disabled when the viewer is embedded in a web page.
Steps to reproduce:
Ctrl+Alt+P.(Note that the toolbar button isn't visible, but that's only because the PDF.js UI is too small.)EDIT: Now that the secondary toolbar has landed, the presentation mode button will be available from it, thus making it a lot easier for the user to enter a non-working presentation mode.Expected result: Presentation mode should either work, or be disabled.
Actual result: (A picture is worth a thousand words...)
This PR adds a check in
PDFView.supportsFullscreento disable presentation mode when the viewer is embedded, to avoid the above issue.