Skip to content

Use the creation date in the popup when there is no modification date #20058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Use the creation date in the popup when there is no modification date #20058

merged 1 commit into from
Jul 7, 2025
+20 −6

Conversation

calixteman
Copy link
Contributor

Remove the h1 element in popup title because it caused a warning in Firefox and use a span instead.

@calixteman calixteman requested a review from timvandermeij July 4, 2025 19:19
@timvandermeij
Copy link
Contributor

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/beb94d5a67033a6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f2b5ae5580c94bd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/f2b5ae5580c94bd/output.txt

Total script time: 31.12 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 41

Image differences available at: http://54.241.84.105:8877/f2b5ae5580c94bd/reftest-analyzer.html#web=eq.log

timvandermeij
timvandermeij approved these changes Jul 6, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the question above addressed. Thanks!

@calixteman calixteman force-pushed the use_creationdate_popup branch from f56de09 to 0d2eb17 Compare July 6, 2025 18:23
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/beb94d5a67033a6/output.txt

Total script time: 51.91 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 41

Image differences available at: http://54.193.163.58:8877/beb94d5a67033a6/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e1ca361c69c75b7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5458eb9dffc3ae9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e1ca361c69c75b7/output.txt

Total script time: 31.02 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5458eb9dffc3ae9/output.txt

Total script time: 50.98 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman
Use the creation date in the popup when there is no modification date
bb52a44 
Remove the h1 element in popup title because it caused a warning in Firefox and use a span instead.
@calixteman calixteman force-pushed the use_creationdate_popup branch from 0d2eb17 to bb52a44 Compare July 7, 2025 08:51
@calixteman calixteman merged commit 729f2bb into mozilla:master Jul 7, 2025
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f5d3aba5b09815d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5d190ece25ce4d6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f5d3aba5b09815d/output.txt

Total script time: 16.09 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5d190ece25ce4d6/output.txt

Total script time: 23.29 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @timvandermeij @moz-tools-bot