[Editor] Add the possibility to add a popup to an annotation when saving #19976
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b92710557233f58/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bd65ce2204ba4f0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/bd65ce2204ba4f0/output.txt Total script time: 29.74 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b92710557233f58/output.txt Total script time: 57.03 mins
|
| @@ -3932,38 +3960,31 @@ class FreeTextAnnotation extends MarkupAnnotation { | |||
| static createNewDict(annotation, xref, { apRef, ap }) { | |||
| const { color, fontSize, oldAnnotation, rect, rotation, user, value } = | |||
| annotation; | |||
| const date = `D:${getModificationDate(annotation.date)}`; | |||
There was a problem hiding this comment.
Here, and elsewhere below:
Looking at the existing code, it doesn't appear that annotation.date is ever being set?
There was a problem hiding this comment.
I had to add it for the test:
https://github.com/mozilla/pdf.js/pull/19976/files#diff-9bc50ce4ba8a4ba8d322114a3cc05fa62005a40b52223059200ca07087dd5a61R12160
in order to have a fixed reference.
After thinking about that, I think it'd make sense to use it when the annotation has been updated and not when it has been saved. I can fix that in a follow-up.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a484cd16b662951/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b21f12f94b94489/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b21f12f94b94489/output.txt Total script time: 30.28 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a484cd16b662951/output.txt Total script time: 56.93 mins
|
When saving/printing, only update the properties which are provided and set a default value only when there is no pre-existing one.
calixteman
requested review from
timvandermeij
and removed request for
Snuffleupagus
When saving/printing, only update the properties which are provided and set a default value only when there is no pre-existing one.