Update Webpack to version 5.99.5 (issue 19808)
#19810
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/204cc78de029e33/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/204cc78de029e33/output.txt Total script time: 0.86 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5dcc16c8c63b94c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/7ba42208e6e600f/output.txt |
In Webpack version `5.99.0` the way that `export` statements are handled was changed slightly, with much less boilerplate code being generated, which unfortunately breaks our `tweakWebpackOutput` function that's used to expose the exported properties globally and that e.g. the viewer depends upon. Given that we were depending on formatting that should most likely be viewed as nothing more than an internal implementation detail in Webpack, we instead work-around this by manually defining the structures that were previously generated. Obviously this will lead to a tiny bit more manual work in the future, however we don't change the API-surface often enough that it should be a big issue *and* the relevant unit-tests are updated such that it shouldn't be possible to break this. *NOTE:* In the future we might want to consider no longer using global properties like this, and instead rely only on proper `export`s throughout the code-base. However changing this would likely be non-trivial (given edge-cases), and it'd be an `api-major` change, so let's just do the minimal amount of work to unblock Webpack updates for now.
Snuffleupagus
force-pushed
the
issue-19808
branch
from
d9936d3 to
6b961c4
Compare
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7ba42208e6e600f/output.txt Total script time: 0.58 mins |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5dcc16c8c63b94c/output.txt Total script time: 30.68 mins
|
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/058eb1bf2e90993/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bd1d307a0de67c1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/058eb1bf2e90993/output.txt Total script time: 2.34 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/bd1d307a0de67c1/output.txt Total script time: 7.96 mins
|
|
I agree that this should be reliable than the previous code. Thank you for fixing this! |
In Webpack version
5.99.0the way thatexportstatements are handled was changed slightly, with much less boilerplate code being generated, which unfortunately breaks ourtweakWebpackOutputfunction that's used to expose the exported properties globally and that e.g. the viewer depends upon.Given that we were depending on formatting that should most likely be viewed as nothing more than an internal implementation detail in Webpack, we instead work-around this by manually defining the structures that were previously generated.
Obviously this will lead to a tiny bit more manual work in the future, however we don't change the API-surface often enough that it should be a big issue and the relevant unit-tests are updated such that it shouldn't be possible to break this.
NOTE: In the future we might want to consider no longer using global properties like this, and instead rely only on proper
exports throughout the code-base.However changing this would likely be non-trivial (given edge-cases), and it'd be an
api-majorchange, so let's just do the minimal amount of work to unblock Webpack updates for now.