-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Move the IDENTITY_MATRIX
constant into src/core/core_utils.js
(PR 19772 follow-up)
#19781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… 19772 follow-up) After the changes in PR 19772 the `IDENTITY_MATRIX` constant is now only used on the worker-thread, which leads to Webpack marking the code as unused in the *built* `pdf.mjs` file; see https://phabricator.services.mozilla.com/D244533#change-8oITAexCvrlQ
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/882d4115cc4f57a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4029da4d9871ed1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4029da4d9871ed1/output.txt Total script time: 30.86 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/882d4115cc4f57a/output.txt Total script time: 62.56 mins
|
Would it be possible to lint that ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Not easily, since linting is run on the source files rather than on the built files. Perhaps we could also try and lint the built files, however that'd likely be problematical since we have limited (if any) control of the output format and comments are stripped during building so we couldn't just add There's also https://webpack.js.org/guides/tree-shaking/ which might help, however it seems like that'd require us to always minify the built files and it's not clear if that'd be desirable (since the code would become unreadable in mozilla-central). |
After the changes in PR #19772 the
IDENTITY_MATRIX
constant is now only used on the worker-thread, which leads to Webpack marking the code as unused in the builtpdf.mjs
file; see https://phabricator.services.mozilla.com/D244533#change-8oITAexCvrlQ