Skip to content

Move the IDENTITY_MATRIX constant into src/core/core_utils.js (PR 19772 follow-up) #19781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

After the changes in PR #19772 the IDENTITY_MATRIX constant is now only used on the worker-thread, which leads to Webpack marking the code as unused in the built pdf.mjs file; see https://phabricator.services.mozilla.com/D244533#change-8oITAexCvrlQ

… 19772 follow-up)

After the changes in PR 19772 the `IDENTITY_MATRIX` constant is now only used on the worker-thread, which leads to Webpack marking the code as unused in the *built* `pdf.mjs` file; see https://phabricator.services.mozilla.com/D244533#change-8oITAexCvrlQ
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/882d4115cc4f57a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4029da4d9871ed1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/4029da4d9871ed1/output.txt

Total script time: 30.86 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/882d4115cc4f57a/output.txt

Total script time: 62.56 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman
Copy link
Contributor

Would it be possible to lint that ?

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Copy link
Collaborator Author

Would it be possible to lint that ?

Not easily, since linting is run on the source files rather than on the built files.

Perhaps we could also try and lint the built files, however that'd likely be problematical since we have limited (if any) control of the output format and comments are stripped during building so we couldn't just add eslint-disable statements where needed.

There's also https://webpack.js.org/guides/tree-shaking/ which might help, however it seems like that'd require us to always minify the built files and it's not clear if that'd be desirable (since the code would become unreadable in mozilla-central).

@Snuffleupagus Snuffleupagus merged commit 1948695 into mozilla:master Apr 8, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the mv-IDENTITY_MATRIX branch April 8, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants