-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Use Array-destructuring when computing MIN/MAX in AFSimple_Calculate
#19775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Array-destructuring when computing MIN/MAX in AFSimple_Calculate
#19775
Conversation
This appears to work fine with QuickJS, as evident by the added unit-test, and allows us to remove more `Array.prototype.reduce` usage.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b5db80abe926db5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/04d336c7b938831/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b5db80abe926db5/output.txt Total script time: 2.29 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/04d336c7b938831/output.txt Total script time: 7.78 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3a1561435b130f0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7899e9fbaa391db/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3a1561435b130f0/output.txt Total script time: 12.25 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7899e9fbaa391db/output.txt Total script time: 32.37 mins
|
Thank you for improving this, and for adding the extra test! |
This appears to work fine with QuickJS, as evident by the added unit-test, and allows us to remove more
Array.prototype.reduce
usage.