Skip to content

Also transfer ImageBitmaps for image masks and inline images #19760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Currently we're only transferring TypedArrays, however there's no reason (as far as I can tell) to not also transfer ImageBitmaps in these cases.

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
LGTM. Thank you.

Currently we're only transferring TypedArrays, however there's no reason (as far as I can tell) to not also transfer `ImageBitmap`s in these cases.
@Snuffleupagus Snuffleupagus force-pushed the OperatorList-transfers-bitmap branch from 4ae319c to 8c5fb79 Compare April 3, 2025 16:50
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c776087714a9ea/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a6a768fa65ede44/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/9c776087714a9ea/output.txt

Total script time: 29.93 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a6a768fa65ede44/output.txt

Total script time: 61.65 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: Passed

@Snuffleupagus Snuffleupagus merged commit 16c8765 into mozilla:master Apr 3, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the OperatorList-transfers-bitmap branch April 3, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants