Use ctx.filter unconditionally in the src/display/canvas.js file
#19756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the `@napi-rs/canvas` dependency has *basic* canvas-filter support, whereas the "old" `canvas` dependency didn't, hence we no longer need the Node.js-specific checks in the `src/display/canvas.js` file. Note that I've successfully tested the [`pdf2png` example](https://github.com/mozilla/pdf.js/tree/master/examples/node/pdf2png) with this patch applied and things appear to work as before.
Snuffleupagus
force-pushed
the
canvas-unconditional-ctx-filter
branch
from
4ddd123 to
0c78b46
Compare
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/751d33ffd788cc2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e9ab19764c6aa03/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/751d33ffd788cc2/output.txt Total script time: 16.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e9ab19764c6aa03/output.txt Total script time: 30.83 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the
@napi-rs/canvasdependency has basic canvas-filter support, whereas the "old"canvasdependency didn't, hence we no longer need the Node.js-specific checks in thesrc/display/canvas.jsfile.Note that I've successfully tested the
pdf2pngexample with this patch applied and things appear to work as before.Smaller diff with https://github.com/mozilla/pdf.js/pull/19756/files?w=1