Skip to content

Change Util.applyTransform to use the point-argument as an in/out parameter #19751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

This will help reduce the total number of Array allocations, which cannot hurt, and also allows us to remove the Util.applyTransformInPlace method.

…arameter

This will help reduce the total number of Array allocations, which cannot hurt, and also allows us to remove the `Util.applyTransformInPlace` method.
…n/out parameter

This will help reduce the total number of Array allocations, which cannot hurt.
Given that all `Util.apply...` methods are now using in/out parameters, we can slightly shorten the name of this one.
@Snuffleupagus Snuffleupagus force-pushed the applyTransform-in-place branch from a9e29d8 to 4262603 Compare April 1, 2025 21:04
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00144d05ffa35bb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6c4f48f80c41ad7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/00144d05ffa35bb/output.txt

Total script time: 29.86 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6c4f48f80c41ad7/output.txt

Total script time: 62.17 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit a45f961 into mozilla:master Apr 2, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the applyTransform-in-place branch April 2, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants