Skip to content

Reduce some code duplication when handling globally cached images #19746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

  • Define the global cache-data once in buildPaintImageXObject

    Currently we duplicate the same identical code three times, which seems both unnecessary and error prone.

  • Use, and re-name, the addLocallyCachedImageOps helper for global images too

    This avoids having to "manually" set the image operators for globally cached images.

Currently we duplicate the same identical code three times, which seems both unnecessary and error prone.
…ages too

This avoids having to "manually" set the image operators for globally cached images.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/32d490ba04a0bea/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c26c03c7cd345fa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/32d490ba04a0bea/output.txt

Total script time: 30.70 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c26c03c7cd345fa/output.txt

Total script time: 60.01 mins

@Snuffleupagus Snuffleupagus requested review from calixteman and removed request for calixteman March 31, 2025 11:24
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit b33522a into mozilla:master Apr 1, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the evaluator-img-cache-tweaks branch April 1, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants