Pass the XRef-instance explicitly to the StructTreeRoot class, and simplify the StructElementNode.prototype.role getter
#19719
Conversation
|
/botio test |
This avoids the current situation where we're accessing it through various dictionaries, since that's a somewhat brittle solution given that in the general case a `Dict`-instance may not have the `xref`-field set (see e.g. the empty-Dict).
Given that the `roleMap` only contains `Name`-strings, the lookup can be simplified thanks to modern JavaScript features.
Snuffleupagus
force-pushed
the
structTree-xref
branch
from
4540ca7 to
5324064
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/54a2b09ab5cac29/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/77fbe70339d0776/output.txt |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.241.84.105:8877/1d73674a13413e4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.193.163.58:8877/1f65c82de2ada61/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/54a2b09ab5cac29/output.txt Total script time: 2.38 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1d73674a13413e4/output.txt Total script time: 12.72 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/77fbe70339d0776/output.txt Total script time: 8.17 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1f65c82de2ada61/output.txt Total script time: 28.84 mins
|
Pass the
XRef-instance explicitly to theStructTreeRootclassThis avoids the current situation where we're accessing it through various dictionaries, since that's a somewhat brittle solution given that in the general case a
Dict-instance may not have thexref-field set (see e.g. the empty-Dict).Simplify the
StructElementNode.prototype.rolegetter a tiny bitGiven that the
roleMaponly containsName-strings, the lookup can be simplified thanks to modern JavaScript features.