Skip to content

Don't overwrite the global alpha when switching to smask mode (bug 1764587) #19717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Don't overwrite the global alpha when switching to smask mode (bug 1764587) #19717

merged 1 commit into from
Mar 25, 2025

Conversation

calixteman
Copy link
Contributor

It fixes #issue16287.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9392878f7a476f9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/37477531dd4099e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/37477531dd4099e/output.txt

Total script time: 30.13 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/37477531dd4099e/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus linked an issue Mar 24, 2025 that may be closed by this pull request
PDF rendering regression after smask changes #14701
Closed
Snuffleupagus
Snuffleupagus approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing multiple old issues by removing code is always nice :-)

r=me, thank you.

@Snuffleupagus Snuffleupagus linked an issue Mar 24, 2025 that may be closed by this pull request
Transparency lost on rendering box shadow #16287
Closed
@marco-c marco-c changed the title Don't overwrite the global alpha when switching to smask mode Don't overwrite the global alpha when switching to smask mode (bug 1764587) Mar 24, 2025
@calixteman calixteman merged commit a8c7763 into mozilla:master Mar 25, 2025
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a686e64f751c8b9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b460b5cede736d7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a686e64f751c8b9/output.txt

Total script time: 15.90 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/b460b5cede736d7/output.txt

Total script time: 30.07 mins

  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the issue16287 branch March 25, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
smask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transparency lost on rendering box shadow PDF rendering regression after smask changes
3 participants
@calixteman @moz-tools-bot @Snuffleupagus