Add new bounding-box helpers in Util to reduce code duplication
#19713
+71
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
Util-minMax-methods
branch
from
c33cf69 to
c7d42d9
Compare
Currently we have a `Util`-helper for computing the bounding-box of a Bézier curve, however for simple points and rectangles we repeat virtually identical code in many spots throughout the code-base. - Introduce new `Util.pointBoundingBox` and `Util.rectBoundingBox` helpers. - Remove the "fallback" from `Util.bezierBoundingBox` and only support passing in a `minMax`-array, since there's only a single call-site using the other format and it could be easily updated.
Snuffleupagus
force-pushed
the
Util-minMax-methods
branch
from
c7d42d9 to
b85f090
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/01fb527ad1cc8d1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/01fb527ad1cc8d1/output.txt Total script time: 29.46 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a
Util-helper for computing the bounding-box of a Bézier curve, however for simple points and rectangles we repeat virtually identical code in many spots throughout the code-base.Introduce new
Util.pointBoundingBoxandUtil.rectBoundingBoxhelpers.Remove the "fallback" from
Util.bezierBoundingBoxand only support passing in aminMax-array, since there's only a single call-site using the other format and it could be easily updated.