Skip to content

Optimize save-transform-constructPath-restore #19712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Optimize save-transform-constructPath-restore #19712

merged 1 commit into from
Apr 1, 2025

Conversation

calixteman
Copy link
Contributor

The 4 operations can be replaced with just one in applying the transform to the points coordinates.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/080fffefa04d659/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0b06274035d985b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0b06274035d985b/output.txt

Total script time: 29.95 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 60

Image differences available at: http://54.241.84.105:8877/0b06274035d985b/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

  • Even though the changes look imperceivable to the naked eye, do we expect movement in "so many" cases simply from a different chunking of the path rendering operators?
  • Any examples of PDFs where this help improve performance, and perhaps also some benchmarking results for this patch?

@calixteman
Copy link
Contributor Author

The "improvement" was a way better when the patch was merging similar constructPath, but as mentioned in general it doesn't work. That said if we're able to know in the worker, that we aren't composing, then we should be able to do something better.
So about the current patch, it mainly helps to remove useless operations.
For example, with issue17779.pdf, on Windows 11, it helps to win ~0.8s when the overall rendering takes 18s:

Snuffleupagus
Snuffleupagus reviewed Mar 25, 2025
View reviewed changes
@calixteman
Optimize save-transform-constructPath-restore
6146e5f 
The 4 operations can be replaced with just one in applying the transform to the points coordinates.
@calixteman calixteman force-pushed the optimize_save_construct branch from 282bbb3 to 6146e5f Compare March 25, 2025 14:31
@calixteman calixteman requested a review from Snuffleupagus April 1, 2025 14:25
@Snuffleupagus
Copy link
Collaborator

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d224fbc887e1544/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5dd3d337d359ccc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/d224fbc887e1544/output.txt

Total script time: 16.26 mins

  • Regression tests: FAILED
  different ref/snapshot: 60

Image differences available at: http://54.241.84.105:8877/d224fbc887e1544/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5dd3d337d359ccc/output.txt

Total script time: 29.78 mins

  • Regression tests: FAILED
  different ref/snapshot: 60

Image differences available at: http://54.193.163.58:8877/5dd3d337d359ccc/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there's some movement I suppose that's not unexpected considering the changes made, and it does appear to be invisible to the naked eye.

r=me, thank you.

@calixteman calixteman merged commit 25693dc into mozilla:master Apr 1, 2025
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/95d88597bf9cf9b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5697a61866b9e69/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/95d88597bf9cf9b/output.txt

Total script time: 16.19 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5697a61866b9e69/output.txt

Total script time: 29.61 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
core performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus