Introduce Math.sumPrecise usage in the code-base
#19710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8d7586d70b89c2f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a19eea9c31b9dae/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a19eea9c31b9dae/output.txt Total script time: 30.27 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8d7586d70b89c2f/output.txt Total script time: 60.02 mins |
timvandermeij
approved these changes
Mar 23, 2025
Snuffleupagus
force-pushed
the
Math-sumPrecise
branch
from
aabaed0 to
04192ef
Compare
This is a new JavaScript feature that makes it easy to compute the sum of list of values; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/sumPrecise This allows us to remove most cases of `Array.prototype.reduce`, which helps improve readability since that (in my opinion) often isn't the most intuitive code.
Snuffleupagus
force-pushed
the
Math-sumPrecise
branch
from
04192ef to
e73224d
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/edf9d36a1987158/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/edf9d36a1987158/output.txt Total script time: 0.86 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new JavaScript feature that makes it easy to compute the sum of list of values; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/sumPrecise
This allows us to remove most cases of
Array.prototype.reduce, which helps improve readability since that (in my opinion) often isn't the most intuitive code.