Fix save/restore while in smask mode

[calixteman]

The rendering bug with issue17779.pdf is due to the fact that we call save on the suspended ctx but not on the the current ctx. So each time we've something like save/transform/restore then the transform not "removed" when restoring.
So this patch just apply the save/restore operations to ctx which are mirrored on the suspended one.

[calixteman]

/botio browsertest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/516d8098f1c4796/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c246e22b12a9c61/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/c246e22b12a9c61/output.txt

Total script time: 15.89 mins

• Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/c246e22b12a9c61/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/516d8098f1c4796/output.txt

Total script time: 29.49 mins

• Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/516d8098f1c4796/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

r=me, thank you.

[Snuffleupagus]

Does this PR perhaps render #17777 obsolete, given #17777 (comment)?

[calixteman]

/botio makeref

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/3c7c991c1e4595e/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/471b0d14206d6f0/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/3c7c991c1e4595e/output.txt

Total script time: 15.78 mins

• Make references: Passed
• Check references: Passed

[calixteman]

Does this PR perhaps render #17777 obsolete, given #17777 (comment)?

Maybe yes.
Out of curiosity, with the mentioned pdf, I checked if the path to stroke is always in the clip box and 5 times the path wasn't inside.
So probably I need to check if not having the path to draw in the clip box is just a corner case or if it's more frequent than I guess. Wdyt ?

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/471b0d14206d6f0/output.txt

Total script time: 29.82 mins

• Make references: Passed
• Check references: Passed

[Snuffleupagus]

Does this PR perhaps render #17777 obsolete, given #17777 (comment)?

Maybe yes. Out of curiosity, with the mentioned pdf, I checked if the path to stroke is always in the clip box and 5 times the path wasn't inside. So probably I need to check if not having the path to draw in the clip box is just a corner case or if it's more frequent than I guess. Wdyt ?

If that's a common case in PDFs with a huge number of path rendering operators, e.g. large maps, then maybe it might make sense to try and avoid pointless stroke; however I've no idea how common that situation is.