Isolate the "move editor with arrows" freetext editor integration tests #19706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces the number of freetext editor integration test suite failures, in full isolation, from 8 to 6 by fixing the following issues in the "move editor with arrows" block: - The second and third test relied on the first test to enable freetext editing mode. For isolation we now do it explicitly in both tests. - The second test relied on the first test having created an editor. For isolation we now create the editor explicitly in the second test. - The third test relied on the previous tests for the editor numbering. For isolation we change the editor numbering to the one after initial document load. Since we can't have state (editors) from a previous test anymore we can remove the `clearAll` call as well.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/94faf78035c9aff/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8701034fec2236d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8701034fec2236d/output.txt Total script time: 12.65 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/94faf78035c9aff/output.txt Total script time: 28.17 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces the number of freetext editor integration test suite failures, in full isolation, from 8 to 6 by fixing the following issues in the "move editor with arrows" block:
clearAllcall as well.Fixes a part of #19065.