Skip to content

Replace the setValues function with Array.prototype.fill() in the src/core/bidi.js file #19703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Replace the setValues function with Array.prototype.fill() in the src/core/bidi.js file #19703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/core/bidi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,6 @@ function findUnequal(arr, start, value) {
return j;
}

function setValues(arr, start, end, value) {
for (let j = start; j < end; ++j) {
arr[j] = value;
}
}

function reverseValues(arr, start, end) {
for (let i = start, j = end - 1; i < j; ++i, --j) {
const temp = arr[i];
Expand Down Expand Up @@ -323,7 +317,7 @@ function bidi(str, startLevel = -1, vertical = false) {
after = "R";
}
if (before === after) {
setValues(types, i, end, before);
types.fill(before, i, end);
}
i = end - 1; // reset to end (-1 so next iteration is ok)
}
Expand Down