Skip to content

Remove Array.prototype.reduce usage from the src/core/xfa/template.js file #19691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

Using Array.prototype.reduce often leads to less readable code, and in these cases we can replace that with other Array-methods instead.

@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b5fe2971bb1633d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d6784dfb26d21a6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/d6784dfb26d21a6/output.txt

Total script time: 16.70 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b5fe2971bb1633d/output.txt

Total script time: 36.70 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@Snuffleupagus Snuffleupagus force-pushed the xfa-template-rm-reduce branch from 8b241db to 0e9a389 Compare March 23, 2025 14:05
….js` file

Using `Array.prototype.reduce` often leads to less readable code, and in these cases we can replace that with other Array-methods instead.
@Snuffleupagus Snuffleupagus force-pushed the xfa-template-rm-reduce branch from 0e9a389 to 9456b88 Compare March 24, 2025 15:40
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 2210714 into mozilla:master Mar 25, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the xfa-template-rm-reduce branch March 25, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants