Skip to content

Fix the "Signature Editor Basic operations must check copy and paste" integration test #19671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Mar 16, 2025

This integration test fails intermittently because of concurrent clipboard access due to running the test in parallel in both browsers. It can be reproduced by introducing await waitForTimeout(1000) between the copy and paste operations.

This commit fixes the issue by running the test sequentially instead, mirroring the change from commit 0e94f2b.

Fixes #19670.

The diff is much smaller with the ?w=1 flag applied; see https://github.com/mozilla/pdf.js/pull/19671/files?w=1.

… integration test

This integration test fails intermittently because of concurrent
clipboard access due to running the test in parallel in both browsers.
It can be reproduced by introducing `await waitForTimeout(1000)` between
the copy and paste operations.

This commit fixes the issue by running the test sequentially instead,
mirroring the change from commit 0e94f2b.
@timvandermeij
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/542c691aa5de614/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fecd4a6dcbe68b4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/542c691aa5de614/output.txt

Total script time: 12.01 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/fecd4a6dcbe68b4/output.txt

Total script time: 27.78 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/795d95920f558f6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3c160a057bdd36d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/795d95920f558f6/output.txt

Total script time: 11.57 mins

  • Integration Tests: FAILED

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/3c160a057bdd36d/output.txt

Total script time: 26.52 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit 92d7b6d into mozilla:master Mar 16, 2025
7 checks passed
@timvandermeij timvandermeij deleted the integration-tests-signature-intermittent branch March 16, 2025 20:35
@timvandermeij timvandermeij removed the request for review from calixteman March 16, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants