-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Fix the "Signature Editor Basic operations must check copy and paste" integration test #19671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the "Signature Editor Basic operations must check copy and paste" integration test #19671
Conversation
… integration test This integration test fails intermittently because of concurrent clipboard access due to running the test in parallel in both browsers. It can be reproduced by introducing `await waitForTimeout(1000)` between the copy and paste operations. This commit fixes the issue by running the test sequentially instead, mirroring the change from commit 0e94f2b.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/542c691aa5de614/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fecd4a6dcbe68b4/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/542c691aa5de614/output.txt Total script time: 12.01 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fecd4a6dcbe68b4/output.txt Total script time: 27.78 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/795d95920f558f6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3c160a057bdd36d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/795d95920f558f6/output.txt Total script time: 11.57 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3c160a057bdd36d/output.txt Total script time: 26.52 mins
|
This integration test fails intermittently because of concurrent clipboard access due to running the test in parallel in both browsers. It can be reproduced by introducing
await waitForTimeout(1000)
between the copy and paste operations.This commit fixes the issue by running the test sequentially instead, mirroring the change from commit 0e94f2b.
Fixes #19670.
The diff is much smaller with the
?w=1
flag applied; see https://github.com/mozilla/pdf.js/pull/19671/files?w=1.