Skip to content

Use arrow function with various Array methods #19596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2025
Merged

Use arrow function with various Array methods #19596

merged 1 commit into from
Mar 2, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

A lot of this is quite old code, which we can shorten slightly by using arrow functions instead of "regular" functions.

@Snuffleupagus
Use arrow function with various Array methods
2e62f42 
A lot of this is quite old code, which we can shorten slightly by using arrow functions instead of "regular" functions.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/37fc72cacc7de3d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8b359ef2d06a1b0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8b359ef2d06a1b0/output.txt

Total script time: 2.37 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/37fc72cacc7de3d/output.txt

Total script time: 8.97 mins

  • Unit Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/17ddbcbec57a5bd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7cb0e925a9386c9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/17ddbcbec57a5bd/output.txt

Total script time: 17.01 mins

  • Regression tests: Passed

timvandermeij
timvandermeij approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thanks!

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7cb0e925a9386c9/output.txt

Total script time: 30.22 mins

  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 146bc58 into mozilla:master Mar 2, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the Array-methods-arrow-functions branch March 2, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core test viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @timvandermeij