Skip to content

Update dependencies and translations to the most recent versions #19542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2025

Conversation

timvandermeij
Copy link
Contributor

The commit messages contain more details about the individual changes.

Fixes a part of #19536.

@Snuffleupagus
Copy link
Collaborator

Upgrade eslint-plugin-unicorn to version 57.0.0

This is a major version bump, but the changelog at
https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v57.0.0
doesn't indicate any breaking changes that should impact us.

Doesn't the first item under the "Improvements" heading apply to us?

  - Deprecate no-instanceof-array (https://github.com/sindresorhus/eslint-plugin-unicorn/pull/2534) https://github.com/sindresorhus/eslint-plugin-unicorn/commit/c9c056c8e0ca8ff16d90f0cc1b4344e683f3c74f

      - Replaced by [no-instanceof-builtin-object](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-instanceof-builtins.md) which covers more cases.

This is a major version bump, but the changelog at
https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v57.0.0
doesn't indicate any breaking changes that should impact us.

However, we do replace the deprecated `no-instanceof-array` rule with
the new `no-instanceof-builtins` rule. Note that the changelog calls
this rule `no-instanceof-builtin-object`, but it got renamed in
sindresorhus/eslint-plugin-unicorn#2537.
This is a major version bump, but the changelog at
https://github.com/sindresorhus/globals/releases/tag/v16.0.0
doesn't indicate any breaking changes that should impact us.
@timvandermeij
Copy link
Contributor Author

Doesn't the first item under the "Improvements" heading apply to us?

Good catch; I missed that. I have updated the patch accordingly.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/748d82f5226dc0a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/748d82f5226dc0a/output.txt

Total script time: 0.99 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d9e81f69edb7c91/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f4b92333e20ad2c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/d9e81f69edb7c91/output.txt

Total script time: 30.38 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f4b92333e20ad2c/output.txt

Total script time: 60.01 mins

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows "failure" is probably because the bots timeout after one hour, which we unfortunately reach nowadays (so I've started running the various test-suites separately to work-around that).

r=me, thank you.

@timvandermeij timvandermeij merged commit fcf94e8 into mozilla:master Feb 23, 2025
7 checks passed
@timvandermeij timvandermeij deleted the updates branch February 23, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants