-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Update dependencies and translations to the most recent versions #19542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doesn't the first item under the "Improvements" heading apply to us?
|
This is a major version bump, but the changelog at https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v57.0.0 doesn't indicate any breaking changes that should impact us. However, we do replace the deprecated `no-instanceof-array` rule with the new `no-instanceof-builtins` rule. Note that the changelog calls this rule `no-instanceof-builtin-object`, but it got renamed in sindresorhus/eslint-plugin-unicorn#2537.
This is a major version bump, but the changelog at https://github.com/sindresorhus/globals/releases/tag/v16.0.0 doesn't indicate any breaking changes that should impact us.
4abe78f
to
33c53df
Compare
Good catch; I missed that. I have updated the patch accordingly. |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/748d82f5226dc0a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/748d82f5226dc0a/output.txt Total script time: 0.99 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d9e81f69edb7c91/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f4b92333e20ad2c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d9e81f69edb7c91/output.txt Total script time: 30.38 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f4b92333e20ad2c/output.txt Total script time: 60.01 mins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows "failure" is probably because the bots timeout after one hour, which we unfortunately reach nowadays (so I've started running the various test-suites separately to work-around that).
r=me, thank you.
The commit messages contain more details about the individual changes.
Fixes a part of #19536.