-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Fix all outstanding ESLint arrow-body-style
warnings
#19504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all outstanding ESLint arrow-body-style
warnings
#19504
Conversation
Currently this rule is disabled in a number of spots across the code-base, and unless absolutely necessary we probably shouldn't disable linting, so let's just update the code to fix all the outstanding cases.
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/52e06b06f6d6060/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d6b3e3bf47592da/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d6b3e3bf47592da/output.txt Total script time: 2.37 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/52e06b06f6d6060/output.txt Total script time: 7.46 mins
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/df9166b69f57e0a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/019bb9c777fa6fb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/019bb9c777fa6fb/output.txt Total script time: 16.74 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/df9166b69f57e0a/output.txt Total script time: 29.98 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Currently this rule is disabled in a number of spots across the code-base, and unless absolutely necessary we probably shouldn't disable linting, so let's just update the code to fix all the outstanding cases.
Smaller diff with https://github.com/mozilla/pdf.js/pull/19504/files?w=1