[api-major] Apply the userUnit using CSS, to fix the text/annotation layers (bug 1947248)
#19469
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ffca678a39ed1e0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ffca678a39ed1e0/output.txt Total script time: 0.87 mins Published |
Snuffleupagus
force-pushed
the
bug-1947248
branch
from
dec5dfb to
f11543e
Compare
Snuffleupagus
force-pushed
the
bug-1947248
branch
4 times, most recently
from
4f7ccf7 to
2bc5a63
Compare
Snuffleupagus
force-pushed
the
bug-1947248
branch
from
2bc5a63 to
37890e6
Compare
…n layers (bug 1947248) Rather than modifying the "raw" dimensions of the page, we'll instead apply the `userUnit` as an *additional* scale-factor via CSS. *Please note:* It's not clear to me if this solution is fully correct either, or if there's other problems with it, but it at least *appears* to work. --- With these changes, the following CSS variables are now assumed to be available/set as necessary: `--total-scale-factor`, `--scale-factor`, `--user-unit`, `--scale-round-x`, and `--scale-round-y`.
Snuffleupagus
force-pushed
the
bug-1947248
branch
from
37890e6 to
bd05b25
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/59a7a46dc1cb5d1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3645f0b0ce0538d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/59a7a46dc1cb5d1/output.txt Total script time: 29.16 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3645f0b0ce0538d/output.txt Total script time: 59.09 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/21c84a1a192100b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/21c84a1a192100b/output.txt Total script time: 0.85 mins Published |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0108eb8085230c2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d2af14d5f25482d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d2af14d5f25482d/output.txt Total script time: 16.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0108eb8085230c2/output.txt Total script time: 29.92 mins
|
Rather than modifying the "raw" dimensions of the page, we'll instead apply the
userUnitas an additional scale-factor via CSS.Please note: It's not clear to me if this solution is fully correct either, or if there's other problems with it, but it at least appears to work.
With these changes, the following CSS variables are now assumed to be available/set as necessary:
--total-scale-factor,--scale-factor,--user-unit,--scale-round-x, and--scale-round-y.