-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Presentation Mode - Replaces #1388 #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio-linux lint |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/8a6728cf927455c/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/654a1a88865534e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/8a6728cf927455c/output.txt Total script time: 0.61 mins Published |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/654a1a88865534e/output.txt Total script time: 1.22 mins
|
Thank you for doing that. There is a strange artifact on the last page: previous page is partially visible. A few notes/question:
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/68588b53660ae0a/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/68588b53660ae0a/output.txt Total script time: 1.20 mins Published |
(Image by shorlander: http://f.cl.ly/items/1i1y170M262l29090T1F/fullscreen.png) /botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d7e226640a9dc55/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d7e226640a9dc55/output.txt Total script time: 0.31 mins Published |
Awesome! +1 from me @brendandahl , could you take a peek as well? |
Nice. Any chance at being able to scroll pages with the mouse wheel? Maybe in a followup update? Also, not sure if it's pdf.js or firefox, but it's VERY slow (~5 seconds) when switching to/from fullscreen here (Firefox 14 in Windows XP). Nice work regardless. |
@gigaherz Thanks. The mouse wheel stuff wouldn't be exactly what I've been aiming at, since this is more of a "presentation" mode / single page mode than a mere "fullscreen" mode. The reason for this is, that if you want to use the mouse wheel, you'll probably not be presenting anything, thus F11 / manual fullscreen migth be better suited? Sounds weird about the slowness. Here it only take half a second or something like that. I don't think it's the implementation as it's super simple, and only calls the respective vendor provided methods for requesting fullscreen ( |
Works very nicely here. Thanks Jakob! |
Presentation Mode - Replaces #1388
Replacing #1388 with this take from scratch which works quite a lot better (probably due to all the contributions to the rendering code since last try.
This PR is essentially the same, with the same changes:
<spacebar>
has been added as a "Next Page" keyHere, both Chrome and Firefox works pretty well with this solution, except a minor difference between the two of them: Firefox seems to handle
padding
andmargin
differently when usingscrollIntoView
- Therefore there is a minor visual difference. Firefox has no "padding" at the top of the window, when using fullscreen mode.As last time: Fixes/Closes #1355 and #1083