[Editor] Ensure that highlightSelection waits until we've fully updated the editing-mode (issue 19369)

[Snuffleupagus]

With the changes in PR #18843 the AnnotationEditorUIManager.prototype.updateMode method is now asynchronous, which we need to take into account when dispatching the "annotationeditormodechanged" event.

Edit: I don't know if this is necessarily the "correct" way to address this, but it appears to work.

[avdoseferovic]

I experienced the similar issue withing the updateMode when using the PdfViewer component. for some reason the next tool gets enabled before the old one is committed / cleaned up. I'm setting the mode with the setter: set annotationEditorMode

can you please also fix it in

pdf_viewer.js L2343

    const updater = () => {
      this.#cleanupSwitchAnnotationEditorMode();
      this.#annotationEditorMode = mode;
      this.#annotationEditorUIManager.updateMode(mode, editId, isFromKeyboard);
      eventBus.dispatch("annotationeditormodechanged", {
        source: this,
        mode,
      });
    };
    

[avdoseferovic]

@Snuffleupagus thank you!

[Snuffleupagus]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3bdc507ef9f123d/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e1b4456801a8926/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/3bdc507ef9f123d/output.txt

Total script time: 10.49 mins

• Integration Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/e1b4456801a8926/output.txt

Total script time: 26.31 mins

• Integration Tests: FAILED

[calixteman]

LGTM. Thank you.