Remove the unused glyphNameMap parameter from Type2Compiled
#19263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/95b365ef9f676f1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/63ad1de89902061/output.txt |
As part of the changes in PR 4259, which landed over ten years ago, the `glyphNameMap` property on `Font`-instances was removed. The reason that this didn't cause any bugs is that we always fallback on `getGlyphsUnicode`, and when using that data we also rely on `StandardEncoding`, hence we should just remove the unused parameter from the `Type2Compiled` constructor.
Snuffleupagus
force-pushed
the
Type2Compiled-fix-glyphNameMap
branch
from
03be21f to
aba6369
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/95b365ef9f676f1/output.txt Total script time: 28.30 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/63ad1de89902061/output.txt Total script time: 52.93 mins
|
timvandermeij
approved these changes
Dec 29, 2024
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the changes in PR #4259, which landed over ten years ago, the
glyphNameMapproperty onFont-instances was removed.The reason that this didn't cause any bugs is that we always fallback on
getGlyphsUnicode, and when using that data we also rely onStandardEncoding, hence we should just remove the unused parameter from theType2Compiledconstructor.