Skip to content

Update Puppeteer to version 21.6.0 and force "CDP" protocol #17393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update Puppeteer to version 21.6.0 and force "CDP" protocol #17393

merged 1 commit into from
Dec 8, 2023

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Dec 8, 2023 •
edited
Loading

Similar to PR #17392 but also enforcing CDP as protocol to workaround a regression in the recent Puppeteer release.

@whimboo
Copy link
Contributor Author

whimboo commented Dec 8, 2023

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @whimboo received. Current queue size: 0

Live output at: http://54.193.163.58:8877/26ee46649f58289/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @whimboo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a1c938f4e54b711/output.txt

@whimboo whimboo mentioned this pull request Dec 8, 2023
Closed
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a1c938f4e54b711/output.txt

Total script time: 24.08 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 17
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/a1c938f4e54b711/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/26ee46649f58289/output.txt

Total script time: 34.78 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/26ee46649f58289/reftest-analyzer.html#web=eq.log

@whimboo
Copy link
Contributor Author

whimboo commented Dec 8, 2023

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @whimboo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/da6d98b6eba7fdf/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @whimboo received. Current queue size: 0

Live output at: http://54.193.163.58:8877/20e3d91c0593eed/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/da6d98b6eba7fdf/output.txt

Total script time: 24.10 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/da6d98b6eba7fdf/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/20e3d91c0593eed/output.txt

Total script time: 35.22 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 14

Image differences available at: http://54.193.163.58:8877/20e3d91c0593eed/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6acdb44ef05bd96/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/863c122133f77ca/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/6acdb44ef05bd96/output.txt

Total script time: 5.71 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/863c122133f77ca/output.txt

Total script time: 16.83 mins

  • Integration Tests: FAILED

calixteman
calixteman approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit 1510360 into mozilla:master Dec 8, 2023
@whimboo whimboo deleted the puppeteer_21.6.0 branch December 8, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whimboo @moz-tools-bot @calixteman