Re-factor the loading-icons used in the viewer toolbars #17287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
CSS-loading-icon
branch
from
3f3bf2e to
7c870ef
Compare
calixteman
reviewed
Nov 18, 2023
Snuffleupagus
force-pushed
the
CSS-loading-icon
branch
from
7c870ef to
aa97126
Compare
Snuffleupagus
force-pushed
the
CSS-loading-icon
branch
2 times, most recently
from
d9ecbdb to
5b2d8b9
Compare
Currently the SVG images for the loading-icons exist in two versions, for the light- respectively dark-theme, which nowadays are the only "duplicated" icons left. The reason for this is that these icons are being used in `input`-elements, where the regular `mask-image` approach used for all buttons don't work. To address this we add containers for the `input`-elements, such that we have a "regular" DOM-element where we can use `mask-image`.
Snuffleupagus
force-pushed
the
CSS-loading-icon
branch
from
5b2d8b9 to
625d4f7
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/20c0f6eddeea22b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/20c0f6eddeea22b/output.txt Total script time: 1.41 mins Published |
calixteman
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the SVG images for the loading-icons exist in two versions, for the light- respectively dark-theme, which nowadays are the only "duplicated" icons left.
The reason for this is that these icons are being used in
input-elements, where the regularmask-imageapproach used for all buttons don't work.To address this we add containers for the
input-elements, such that we have a "regular" DOM-element where we can usemask-image.Edit: This reduces the size of the
gulp mozcentraloutput by1.5kilo-bytes, which isn't a lot but still cannot hurt.