Use CSS nesting in the annotationLayer #17196
Conversation
Snuffleupagus
force-pushed
the
annotationLayer-css-nesting
branch
from
62ea2bc to
b779e41
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0a2081c69daede4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ab2483754784ef0/output.txt |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/b049a77ceda5b78/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0a2081c69daede4/output.txt Total script time: 25.15 mins
Image differences available at: http://54.241.84.105:8877/0a2081c69daede4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b049a77ceda5b78/output.txt Total script time: 1.44 mins Published |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ab2483754784ef0/output.txt Total script time: 36.21 mins
Image differences available at: http://54.193.163.58:8877/ab2483754784ef0/reftest-analyzer.html#web=eq.log |
|
@calixteman I've addressed your comments in a separate commit, mind re-reviewing that part? |
In order to do that we must change the text layer opacity to 1 but it has several implications: - the selection color must have an alpha component, - the background color of the span used for highlighted words must have an alpha component either, but now the opacity is 1 we can use some backdrop-filters in HCM making the highlighted words more visible. - fix a regression caused by mozilla#17196: the css variable --hcm-highlight-filter has to live under the #viewer element because in HCM it's overwritten by js at this level, hence links annotations for example didn't have the right colors when hovered.
In order to do that we must change the text layer opacity to 1 but it has several implications: - the selection color must have an alpha component, - the background color of the span used for highlighted words must have an alpha component either, but now the opacity is 1 we can use some backdrop-filters in HCM making the highlighted words more visible. - fix a regression caused by mozilla#17196: the css variable --hcm-highlight-filter has to live under the #viewer element because in HCM it's overwritten by js at this level, hence links annotations for example didn't have the right colors when hovered.
In order to do that we must change the text layer opacity to 1 but it has several implications: - the selection color must have an alpha component, - the background color of the span used for highlighted words must have an alpha component either, but now the opacity is 1 we can use some backdrop-filters in HCM making the highlighted words more visible. - fix a regression caused by mozilla#17196: the css variable --hcm-highlight-filter has to live under the #viewer element because in HCM it's overwritten by js at this level, hence links annotations for example didn't have the right colors when hovered.
No description provided.