Fix integration tests on Mac #17189
Fix integration tests on Mac #17189
Conversation
|
FYI, locally everything is green on Mac, Linux (Ubuntu through WSL2 on Windows 11) and Windows. |
There was a problem hiding this comment.
It's mainly a matter of keyboard shortcuts.
And it fixes few intermittents.
Could these two things perhaps be split into two separate commits (but in the same PR), since fixing the keyboard shortcuts feels like a mostly mechanical change and given the size of this it's a bit difficult to (easily) spot the "intermittents"-part?
calixteman
force-pushed
the
mac_integration_test
branch
from
7daae99 to
9f7466f
Compare
|
Closes #17181. |
|
I can confirm that this PR fixes all the issues that I have seen over on #17181 for both Firefox and Chrome with the CDP protocol enabled. Thanks a lot! |
calixteman
force-pushed
the
mac_integration_test
branch
from
9f7466f to
983f2af
Compare
the page is displayed in using page-fit in order to make all tested elements visible.
calixteman
force-pushed
the
mac_integration_test
branch
from
983f2af to
d72fd9c
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5de11bf7442c855/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fd28713f242b505/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5de11bf7442c855/output.txt Total script time: 5.42 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fd28713f242b505/output.txt Total script time: 16.74 mins
|
|
Thank you for doing this; extracting those helper functions makes the individual tests easier! |
It's mainly a matter of keyboard shortcuts.
And it fixes few intermittents.