Use a ResizeObserver to update the layout of PDFFindBar
#17152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Please note:* In the Firefox PDF Viewer this findbar is only used for PDF documents placed in e.g. `<iframe>` elements. By registering a `ResizeObserver` when the `PDFFindBar` is open we slightly unify and simplify how the findbar layout (row vs column) is handled. This will be especially helpful with upcoming changes, where we'll make use of "data-l10n-id"/"data-l10n-args" to trigger translation in the viewer.
Snuffleupagus
force-pushed
the
findbar-resizeObserver
branch
from
2e4f582 to
e20ef39
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5d776faa3756ea9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5d776faa3756ea9/output.txt Total script time: 1.44 mins Published |
|
Can't we achieve the same layout change with flex-wrap ? |
|
Ok, that's unfortunate, that said I way prefer this solution (i.e. the one in this patch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: In the Firefox PDF Viewer this findbar is only used for PDF documents placed in e.g.
<iframe>elements.By registering a
ResizeObserverwhen thePDFFindBaris open we slightly unify and simplify how the findbar layout (row vs column) is handled.This will be especially helpful with upcoming changes, where we'll make use of "data-l10n-id"/"data-l10n-args" to trigger translation in the viewer.