Use a standard export statement in the web/pdfjs.js file
#17052
Conversation
This removes the only remaining old and non-standard handling of exports in the `web/`-folder, since some initial attempts at outputting JavaScript modules in the builds have identified this file as a potential problem. While this uses a hard-coded list, for overall simplicity, I don't believe that that's a big problem since: - Generating this file automatically would require a bunch more parsing *every single time* that the library is built. - The official API-surface doesn't change often enough for this to really impede development in any significant way. - The added unit-test helps ensure that this list cannot accidentally become outdated.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/518d02d79a59a0d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/518d02d79a59a0d/output.txt Total script time: 1.43 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4d8a6174e51e460/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/30b9b37432b164b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/30b9b37432b164b/output.txt Total script time: 27.65 mins
Image differences available at: http://54.241.84.105:8877/30b9b37432b164b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4d8a6174e51e460/output.txt Total script time: 28.22 mins
Image differences available at: http://54.193.163.58:8877/4d8a6174e51e460/reftest-analyzer.html#web=eq.log |
|
Thanks! |
|
Note that I have WIP patches that convert our builds to output JavaScript modules, and to my surprise this actually seems to work quite well in browsers; see master...Snuffleupagus:pdf.js:output-modules However, as expected, getting Node.js to work is turning out to be more of a challenge unfortunately :-( |
This removes the only remaining old and non-standard handling of exports in the
web/-folder, since some initial attempts at outputting JavaScript modules in the builds have identified this file as a potential problem.While this uses a hard-coded list, for overall simplicity, I don't believe that that's a big problem since: