Skip to content

[Editor] Remove the class fooEditing from the layer when destroying it #17030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

calixteman
Copy link
Contributor

and simplify the way to handle the different types of editors.

@calixteman
Copy link
Contributor Author

These type tests are painful...

@calixteman calixteman force-pushed the editor_remove_editing_class branch from efff58f to a25d623 Compare September 25, 2023 14:16
@calixteman calixteman force-pushed the editor_remove_editing_class branch from a25d623 to 159b66a Compare September 25, 2023 15:58
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with one more suggestion; thank you!

and simplify the way to handle the different types of editors.
@calixteman calixteman force-pushed the editor_remove_editing_class branch from 159b66a to 71376f0 Compare September 25, 2023 16:56
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ac94dc46f5ea4c3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8e07399ad97b586/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ac94dc46f5ea4c3/output.txt

Total script time: 5.36 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/8e07399ad97b586/output.txt

Total script time: 18.76 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 5f75404 into mozilla:master Sep 25, 2023
@calixteman calixteman deleted the editor_remove_editing_class branch September 25, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants