-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Editor] Remove the class fooEditing from the layer when destroying it #17030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Remove the class fooEditing from the layer when destroying it #17030
Conversation
These type tests are painful... |
efff58f
to
a25d623
Compare
a25d623
to
159b66a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with one more suggestion; thank you!
and simplify the way to handle the different types of editors.
159b66a
to
71376f0
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ac94dc46f5ea4c3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8e07399ad97b586/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ac94dc46f5ea4c3/output.txt Total script time: 5.36 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8e07399ad97b586/output.txt Total script time: 18.76 mins
|
and simplify the way to handle the different types of editors.