Skip to content

Update Puppeteer to the latest version #17027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2023
Merged

Update Puppeteer to the latest version #17027

merged 1 commit into from
Sep 28, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This also required updating the postinstall-step to account for recent changes in Puppeteer.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@mozilla mozilla deleted a comment from moz-tools-bot Sep 26, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Sep 26, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Sep 26, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Sep 26, 2023
@Snuffleupagus
Copy link
Collaborator Author

Given that Firefox Nightly was just updated to version 120, let's re-run the tests to check that nothing else is broken here.

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3a5359575d63e25/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2ff1739858d269e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/3a5359575d63e25/output.txt

Total script time: 27.52 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 186
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/3a5359575d63e25/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2ff1739858d269e/output.txt

Total script time: 37.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 27

Image differences available at: http://54.193.163.58:8877/2ff1739858d269e/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Update Puppeteer to the latest version
790b480 
This also required updating the `postinstall`-step to account for recent changes in Puppeteer.
calixteman
calixteman approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 46d8d36 into mozilla:master Sep 28, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/065e59c858ba2ba/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2ffe55d45061fbd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/065e59c858ba2ba/output.txt

Total script time: 22.16 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2ffe55d45061fbd/output.txt

Total script time: 23.88 mins

  • Lint: Passed
  • Make references: FAILED

@calixteman
Copy link
Contributor

/botio-windows makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1921e751cf9dd2e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1921e751cf9dd2e/output.txt

Total script time: 24.20 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the update-Puppeteer branch September 28, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman