Skip to content

Remove the enableStampEditor preference #17006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Sep 22, 2023

Just in case, do we need to hold off landing this until https://bugzilla.mozilla.org/show_bug.cgi?id=1843054 reaches Firefox release?

@Snuffleupagus Snuffleupagus force-pushed the rm-enableStampEditor-pref branch from 0af0ecb to 5803211 Compare September 23, 2023 15:43
@Snuffleupagus Snuffleupagus marked this pull request as ready for review October 1, 2023 21:01
@calixteman
Copy link
Contributor

I forgot about this PR and it was a good idea :)
We want to make an experiment with Nimbus hence we need to keep the pref for the moment.

@Snuffleupagus Snuffleupagus force-pushed the rm-enableStampEditor-pref branch from 5803211 to e820688 Compare October 19, 2023 13:45
@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Oct 25, 2023

Given https://bugzilla.mozilla.org/show_bug.cgi?id=1859806, can we land this now?

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 0fc8993 into mozilla:master Oct 25, 2023
@Snuffleupagus Snuffleupagus deleted the rm-enableStampEditor-pref branch October 25, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants