-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Editor] Tweak few values after review from UX #16988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a0758fa83007a4a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a0758fa83007a4a/output.txt Total script time: 1.56 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why two separate commits, given that the commit messages are identical?
Also, please add a bit more context about the changes since there's a lot of slightly unrelated changes being made all at once here.
cdf2c19
to
3c0791b
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b7463b252334cee/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b7463b252334cee/output.txt Total script time: 1.75 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not particularly happy about leaving #16988 (comment) unaddressed, so if we could figure some way of improve things (in a follow-up) that would be nice.
3c0791b
to
a719f99
Compare
I think I've an idea, I just tried: &::backdrop {
clip-path: circle(40%);
} and it works so in setting the right path (especially in order to consider the "outside" of the rectangle containing the selected editor) it should be possible to darken everything except the editor. |
a719f99
to
b5d1800
Compare
No description provided.