Skip to content

[Editor] Tweak few values after review from UX #16988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from a team as a code owner September 20, 2023 16:36
@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a0758fa83007a4a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a0758fa83007a4a/output.txt

Total script time: 1.56 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two separate commits, given that the commit messages are identical?
Also, please add a bit more context about the changes since there's a lot of slightly unrelated changes being made all at once here.

@calixteman calixteman force-pushed the alt_text_dialog_others branch 2 times, most recently from cdf2c19 to 3c0791b Compare September 20, 2023 18:31
@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b7463b252334cee/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/b7463b252334cee/output.txt

Total script time: 1.75 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not particularly happy about leaving #16988 (comment) unaddressed, so if we could figure some way of improve things (in a follow-up) that would be nice.

@calixteman calixteman force-pushed the alt_text_dialog_others branch from 3c0791b to a719f99 Compare September 20, 2023 20:06
@calixteman
Copy link
Contributor Author

I'm still not particularly happy about leaving #16988 (comment) unaddressed, so if we could figure some way of improve things (in a follow-up) that would be nice.

I think I've an idea, I just tried:

  &::backdrop {
    clip-path: circle(40%);
  }

and it works so in setting the right path (especially in order to consider the "outside" of the rectangle containing the selected editor) it should be possible to darken everything except the editor.
I'll do that in a follow-up.

@calixteman calixteman force-pushed the alt_text_dialog_others branch from a719f99 to b5d1800 Compare September 21, 2023 08:53
@calixteman calixteman merged commit 237b8ce into mozilla:master Sep 21, 2023
@calixteman calixteman deleted the alt_text_dialog_others branch September 21, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants