[Editor] Allow the user to add and save an alt-text for images (bug 1844952)

[calixteman]

No description provided.

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/061189fce12d5cd/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/061189fce12d5cd/output.txt

Total script time: 1.46 mins

Published

• Viewer: http://54.241.84.105:8877/061189fce12d5cd/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/061189fce12d5cd/legacy/web/viewer.html

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00b2ab67eb04400/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/00b2ab67eb04400/output.txt

Total script time: 1.45 mins

Published

• Viewer: http://54.241.84.105:8877/00b2ab67eb04400/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/00b2ab67eb04400/legacy/web/viewer.html

[Snuffleupagus]

There seem to be some problem with the dialog position in RTL-mode, since its right side is always aligned with the right edge of the browser window:

[Snuffleupagus]

Possibly better suited for a follow-up: Looking at the specification it appears that the text-color of the textarea should become "greyed out" when Mark as decorative active, and that doesn't seem to happen currently.

[Snuffleupagus]

There's potentially one (small) problem with positioning the dialog absolutely in the way that we're doing here, which is that if the browser window is resized to become smaller after the dialog has been opened (I happened to trigger this by opening the devtools) then part of the altText dialog will be invisible/inaccessible.

One possible, simple way, around that might be to pass in the eventBus to the AltTextManager and add a listener for "resize" on it and reset the dialog left/top values to auto if a resize event occurs while the dialog is open?

[calixteman]

There seem to be some problem with the dialog position in RTL-mode, since its right side is always aligned with the right edge of the browser window:

It's strange: nothing happens if I change left in devtools but if use right instead it's ok.
I tried to write a basic test case but everything works fine.

[Snuffleupagus]

r=me, with one more comment; thank you!