Fix integration test "Interaction in bug1844576.pdf must check that a field has the correct formatted value" #16962
Conversation
We already use `page.$eval` in most other integration tests and it's simpler because it already takes the selector as argument, so we don't have to do a separate `querySelector` call ourselves.
…test This integration test currently fails intermittently on the bots because of the fixed timeout in the test, which is sometimes too low on slower systems. The issue can be reproduced 100% of the time by introducing a delay in the `WidgetAnnotationElement.showElementAndHideCanvas` method. Puppeteer also discourages this and instead recommends waiting for a selector instead, which we now do here. This ensures that the test only continues if the element under test is available and therefore prevents any timing problems.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3d76fd15844cca9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c8fdc15bbc645e4/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3d76fd15844cca9/output.txt Total script time: 4.81 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c8fdc15bbc645e4/output.txt Total script time: 16.48 mins
|
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2c8d23ac230c4a9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2c8d23ac230c4a9/output.txt Total script time: 4.86 mins
|
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b2c2efeeaa63c12/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b2c2efeeaa63c12/output.txt Total script time: 4.84 mins
|
This is part 1 of the work to create tickets for and on a case-by-case basis fix intermittently failing integration tests.
The commit messages contain more information about the individual changes.
Fixes #16930.