-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Make annotations focusable (bug 1851489) #16898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make annotations focusable (bug 1851489) #16898
Conversation
31c8aa8
to
00ee001
Compare
00ee001
to
8ae0516
Compare
When the annotation has a popup then the popup can be toggled in using the Enter key and hidden in using the Escape key.
8ae0516
to
7f44f35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing tests; thank you!
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/26a7a0c7ed55b64/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/48c228019732616/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/48c228019732616/output.txt Total script time: 4.62 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/26a7a0c7ed55b64/output.txt Total script time: 19.88 mins
|
When the annotation has a popup then the popup can be toggled in using the Enter key and hidden in using the Escape key.