Skip to content

Make annotations focusable (bug 1851489) #16898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

calixteman
Copy link
Contributor

When the annotation has a popup then the popup can be toggled in using the Enter key and hidden in using the Escape key.

@calixteman calixteman marked this pull request as draft September 4, 2023 14:23
@calixteman calixteman force-pushed the make_annotation_focusable branch from 31c8aa8 to 00ee001 Compare September 4, 2023 14:35
@calixteman calixteman marked this pull request as ready for review September 4, 2023 14:36
@calixteman calixteman force-pushed the make_annotation_focusable branch from 00ee001 to 8ae0516 Compare September 4, 2023 14:56
When the annotation has a popup then the popup can be toggled in using
the Enter key and hidden in using the Escape key.
@calixteman calixteman force-pushed the make_annotation_focusable branch from 8ae0516 to 7f44f35 Compare September 4, 2023 15:12
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/26a7a0c7ed55b64/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/48c228019732616/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/48c228019732616/output.txt

Total script time: 4.62 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/26a7a0c7ed55b64/output.txt

Total script time: 19.88 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 08f9e48 into mozilla:master Sep 4, 2023
@calixteman calixteman deleted the make_annotation_focusable branch September 4, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants