Skip to content

Add tagged annotations in the structure tree (bug 1850797) #16886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add tagged annotations in the structure tree (bug 1850797) #16886

merged 1 commit into from
Aug 31, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman force-pushed the struct_tree_annotation branch from b296b53 to 12cf8df Compare August 30, 2023 18:54
Snuffleupagus
Snuffleupagus requested changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a quick look, I've got a few questions and suggestions.

@calixteman calixteman force-pushed the struct_tree_annotation branch from 12cf8df to 6ce738e Compare August 30, 2023 20:52
@Snuffleupagus
Copy link
Collaborator

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/baa4ede2bc9f0be/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ba25d7b4a2bb32a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/baa4ede2bc9f0be/output.txt

Total script time: 27.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 12

Image differences available at: http://54.241.84.105:8877/baa4ede2bc9f0be/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ba25d7b4a2bb32a/output.txt

Total script time: 40.90 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 27

Image differences available at: http://54.193.163.58:8877/ba25d7b4a2bb32a/reftest-analyzer.html#web=eq.log

@Snuffleupagus

This comment was marked as resolved.

Sign in to view
@calixteman calixteman force-pushed the struct_tree_annotation branch from 6ce738e to 1ffa5db Compare August 31, 2023 10:15
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Aug 31, 2023 •
edited
Loading

The last update seems to have accidentally reverted most (if not all) of the previously fixed comments, please fix that so that I can approve the patch :-)

@calixteman calixteman force-pushed the struct_tree_annotation branch from 1ffa5db to d185db2 Compare August 31, 2023 10:35
Snuffleupagus
Snuffleupagus approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems much nicer now; I'd suggest running the integrationtest once more before landing it.

r=me, thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fbe0308ee9711fa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d405c6df0184937/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fbe0308ee9711fa/output.txt

Total script time: 5.11 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d405c6df0184937/output.txt

Total script time: 21.69 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 20b0be9 into mozilla:master Aug 31, 2023
@calixteman calixteman deleted the struct_tree_annotation branch August 31, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @Snuffleupagus @moz-tools-bot