Skip to content

Take fill-alpha into account with default icons for FileAttachment annotations (issue 16800) #16804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

Take fill-alpha into account with default icons for FileAttachment annotations (issue 16800) #16804

merged 1 commit into from
Aug 8, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus Snuffleupagus linked an issue Aug 8, 2023 that may be closed by this pull request
How do I remove embedded images #16800
Closed
@Snuffleupagus Snuffleupagus force-pushed the issue-16800 branch 5 times, most recently from 1a95332 to 3850ffc Compare August 8, 2023 12:20
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/16a20f89233c643/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/20a017308e9702f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/20a017308e9702f/output.txt

Total script time: 26.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/20a017308e9702f/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/16a20f89233c643/output.txt

Total script time: 39.48 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 26

Image differences available at: http://54.193.163.58:8877/16a20f89233c643/reftest-analyzer.html#web=eq.log

calixteman
calixteman reviewed Aug 8, 2023
View reviewed changes
calixteman
calixteman approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Copy link
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dab2a3b928b3c40/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/4fca32b4a091939/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dab2a3b928b3c40/output.txt

Total script time: 21.52 mins

  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/dab2a3b928b3c40/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4fca32b4a091939/output.txt

Total script time: 24.59 mins

  • Regression tests: FAILED
  different ref/snapshot: 29
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/4fca32b4a091939/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 2e9f2e6 into mozilla:master Aug 8, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c0cc18f6a821d94/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3f229c1f5ac875a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3f229c1f5ac875a/output.txt

Total script time: 21.86 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/c0cc18f6a821d94/output.txt

Total script time: 25.47 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-16800 branch August 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do I remove embedded images
3 participants
@Snuffleupagus @moz-tools-bot @calixteman