Attempt to expose e.g. pdfjsLib globally regardless of how the library is imported (issue 16778)
#16790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the built --- C:\Users\Jonas\Desktop\pdf.js
+++ C:\Users\Jonas\Git\pdf.js\build\generic\build\pdf.js
@@ -22,11 +22,11 @@
(function webpackUniversalModuleDefinition(root, factory) {
if(typeof exports === 'object' && typeof module === 'object')
- module.exports = factory();
+ module.exports = root.pdfjsLib = factory();
else if(typeof define === 'function' && define.amd)
- define("pdfjs-dist/build/pdf", [], factory);
+ define("pdfjs-dist/build/pdf", [], () => { return (root.pdfjsLib = factory()); });
else if(typeof exports === 'object')
- exports["pdfjs-dist/build/pdf"] = factory();
+ exports["pdfjs-dist/build/pdf"] = root.pdfjsLib = factory();
else
root["pdfjs-dist/build/pdf"] = root.pdfjsLib = factory();
})(globalThis, () => {
@@ -966,7 +966,7 @@
}
const fetchDocParams = {
docId,
- apiVersion: '3.10.23',
+ apiVersion: '3.10.24',
data,
password,
disableAutoFetch,
@@ -2723,9 +2723,9 @@
}
}
}
-const version = '3.10.23';
+const version = '3.10.24';
exports.version = version;
-const build = '2747928a5';
+const build = '70a1cc5b0';
exports.build = build;
/***/ }),
@@ -17470,8 +17470,8 @@
var _annotation_layer = __w_pdfjs_require__(29);
var _worker_options = __w_pdfjs_require__(14);
var _xfa_layer = __w_pdfjs_require__(32);
-const pdfjsVersion = '3.10.23';
-const pdfjsBuild = '2747928a5';
+const pdfjsVersion = '3.10.24';
+const pdfjsBuild = '70a1cc5b0';
})();
/******/ return __webpack_exports__; |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/29a9816998e5997/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/72079013018d43f/output.txt |
…ary is imported (issue 16778) We obviously don't want to re-introduce any `require` usage in e.g. the viewer, since we should strive to only use native `import` statements wherever possible.[1] Hopefully exposing e.g. the library globally in more cases won't break anything, however it's somewhat difficult for me to imagine all the ways in which third-party users may be accessing the PDF.js library. (Given the lack of a runnable test-case in the issue, I also cannot guarantee that this is enough to fully address the problem.) --- [1] Ideally we should probably not rely on e.g. `pdfjsLib` being globally available in the *built* viewer, and rather always `import` the library instead. Unfortunately this would require larger (possibly breaking) changes in the builds that we provide, however note that Firefox only recently got support for `import` in workers and that Webpack still only have *experimental* support for outputting "proper" modules.
Snuffleupagus
force-pushed
the
addGlobalExports
branch
from
70a1cc5 to
42e6243
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/29a9816998e5997/output.txt Total script time: 27.21 mins
Image differences available at: http://54.241.84.105:8877/29a9816998e5997/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/72079013018d43f/output.txt Total script time: 39.14 mins
Image differences available at: http://54.193.163.58:8877/72079013018d43f/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Aug 6, 2023
|
Looks good to me; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We obviously don't want to re-introduce any
requireusage in e.g. the viewer, since we should strive to only use nativeimportstatements wherever possible.[1]Hopefully exposing e.g. the library globally in more cases won't break anything, however it's somewhat difficult for me to imagine all the ways in which third-party users may be accessing the PDF.js library. (Given the lack of a runnable test-case in the issue, I also cannot guarantee that this is enough to fully address the problem.)
[1] Ideally we should probably not rely on e.g.
pdfjsLibbeing globally available in the built viewer, and rather alwaysimportthe library instead.Unfortunately this would require larger (possibly breaking) changes in the builds that we provide, however note that Firefox only recently got support for
importin workers and that Webpack still only have experimental support for outputting "proper" modules.