Skip to content

Don't uselessly change the filter when drawing (bug 1508765) #16722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Don't uselessly change the filter when drawing (bug 1508765) #16722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/display/canvas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,10 @@ function resetCtxToDefault(ctx) {
(typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) ||
!isNodeJS
) {
ctx.filter = "none";
const { filter } = ctx;
if (filter !== "none" && filter !== "") {
ctx.filter = "none";
}
}
}

Expand Down Expand Up @@ -2961,7 +2964,10 @@ class CanvasGraphics {
// It must be applied to the image before rescaling else some artifacts
// could appear.
// The final restore will reset it to its value.
ctx.filter = "none";
const { filter } = ctx;
if (filter !== "none" && filter !== "") {
ctx.filter = "none";
}
}

// scale the image to the unit square
Expand Down