[GeckoView] Fix l10n of the download toolbar-button (PR 16340 follow-up)

[Snuffleupagus]

Localization of this button broke in PR #16340, which I assume was completely accidental, since the download-button now tries to access a l10n-id that was removed some time ago (see PR #15617).
Note how loading even the development viewer, i.e. http://localhost:8888/web/viewer-geckoview.html#locale=en-US, currently logs l10n-warnings on the master branch.

[calixteman]

Thank you.
I've no idea on how I did that...

[calixteman]

This change induced a test failure with Fenix:
mozilla-mobile/firefox-android#2954 (comment)
After thinking about that, the "Download" string is what we must have ("must" because it has been decided by UI) and we must add a new localized string.
Sorry about having r+ed this PR.

[Snuffleupagus]

After thinking about that, the "Download" string is what we must have ("must" because it has been decided by UI) and we must add a new localized string.

Well, to me it does seem strange to use different strings for the same functionality in the regular vs. GeckoView versions of the viewer. Shouldn't we perhaps ask UI about addressing this inconsistency?

[calixteman]

The main difference between Fenix and desktop is that the string is displayed in Fenix when it isn't in desktop.
That said I'll submit the question to the fenix UI team because when we've a filed form we're closer to "Save" than "Download".

[calixteman]

After thinking about that, the "Download" string is what we must have ("must" because it has been decided by UI) and we must add a new localized string.

Well, to me it does seem strange to use different strings for the same functionality in the regular vs. GeckoView versions of the viewer. Shouldn't we perhaps ask UI about addressing this inconsistency?

I agree with you and I raised the question to the team, so wait and see.

[calixteman]

I got an answer from the android UX/UI team and they decided to keep the string "Download" even if they agreed that technically it's more a saving than a downloading. That said it's something which could change in the future.