Skip to content

[ESM] Convert the gulpfile to use standard modules #16668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This is a necessary intermediate step to allow converting files in the external/builder/ folder.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the merge conflict addressed; thanks!

This is a necessary intermediate step to allow converting files in the `external/builder/` folder.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ff3ccbaa678a66c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ff3ccbaa678a66c/output.txt

Total script time: 0.57 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1f6751b88bbcdea/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a74c783dd74e9e3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/1f6751b88bbcdea/output.txt

Total script time: 0.70 mins

  • Font tests: FAILED
  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.241.84.105:8877/1f6751b88bbcdea/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a74c783dd74e9e3/output.txt

Total script time: 38.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 31

Image differences available at: http://54.193.163.58:8877/a74c783dd74e9e3/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

It's weird that only the Linux-bot fails completely, with messages such as below.
My only guess is that it might be related to the gulp-cli package, since that's not automatically installed; maybe the Linux-bot uses an outdated version?

@calixteman Can you please run npm install -g gulp-cli on the Linux-bot, to see if that fixes things?

>> Making web site
[14:03:58] No gulpfile found
>> Running tests
[14:11:41] No gulpfile found
!botio_message:+ **Font tests:** FAILED
!botio_message:+ **Unit tests:** FAILED
!botio_message:+ **Integration Tests:** FAILED
!botio_message:+ **Regression tests:** FAILED

@calixteman
Copy link
Contributor

/botio-linux test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/2fa514d30054bc2/output.txt

@calixteman
Copy link
Contributor

/botio-linux test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 2

Live output at: http://54.241.84.105:8877/768027f862568d6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2fa514d30054bc2/output.txt

Total script time: 24.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 13
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/2fa514d30054bc2/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/768027f862568d6/output.txt

Total script time: 25.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/768027f862568d6/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

That seems to have worked, thank you @calixteman

@Snuffleupagus Snuffleupagus merged commit bcf14a4 into mozilla:master Jul 11, 2023
@Snuffleupagus Snuffleupagus deleted the esm-gulpfile branch July 11, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants